Deprecation of str::slice_unchecked(_mut) #51807

newpavlov · 2018-06-26T10:41:22Z

I am not sure if 1.28.0 or 1.29.0 should be used for deprecation version, for now it's 1.28.0.

Additionally I've replaced slice_unchecked uses with get_unchecked. The only places where this method is still used are src/liballoc/tests/str.rs and src/liballoc/tests/str.rs.

rust-highfive · 2018-06-26T10:41:34Z

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

kennytm · 2018-06-26T18:17:12Z

src/libcore/str/mod.rs

@@ -2453,6 +2453,7 @@ impl str {
    /// }
    /// ```
    #[stable(feature = "rust1", since = "1.0.0")]
+    #[rustc_deprecated(since = "1.28.0", reason = "duplicates `get_unchecked`")]


I am not sure if 1.28.0 or 1.29.0 should be used for deprecation version

It should be 1.29.0 (or higher).

kennytm · 2018-06-26T18:17:22Z

src/libcore/str/mod.rs

@@ -2483,6 +2484,7 @@ impl str {
    /// * `begin` and `end` must be byte positions within the string slice.
    /// * `begin` and `end` must lie on UTF-8 sequence boundaries.
    #[stable(feature = "str_slice_mut", since = "1.5.0")]
+    #[rustc_deprecated(since = "1.28.0", reason = "duplicates `get_unchecked`")]


get_unchecked_mut.

TimNN · 2018-07-03T17:36:33Z

Ping from triage, @Mark-Simulacrum, this PR needs your review!

pietroalbini · 2018-07-09T11:05:01Z

Ping from triage! This PR needs a review, can @Mark-Simulacrum or someone else from @rust-lang/libs review this?

SimonSapin · 2018-07-09T12:27:30Z

Looks fine to me, but since this is affecting stable APIs let’s go through the process:

@rfcbot fcp merge

rfcbot · 2018-07-09T12:27:30Z

Team member @SimonSapin has proposed to merge this. The next step is review by the rest of the tagged teams:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

rfcbot · 2018-07-11T04:17:00Z

🔔 This is now entering its final comment period, as per the review above. 🔔

RalfJung · 2018-07-12T10:51:38Z

The deprecation message could indicate that one can call get_unchecked(start..len), which was not immediately obvious to me.

SimonSapin · 2018-07-12T11:32:15Z

Yes, except it’s start..end :)

RalfJung · 2018-07-12T11:48:49Z

oops well, that then :)

rfcbot · 2018-07-21T04:18:19Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

alexcrichton · 2018-07-21T15:43:50Z

@bors: r+

Ok great!

bors · 2018-07-21T15:43:51Z

📌 Commit 808bcfb has been approved by alexcrichton

kennytm · 2018-07-21T15:45:00Z

@bors rollup

…excrichton Deprecation of str::slice_unchecked(_mut) Closes rust-lang#51715 I am not sure if 1.28.0 or 1.29.0 should be used for deprecation version, for now it's 1.28.0. Additionally I've replaced `slice_unchecked` uses with `get_unchecked`. The only places where this method is still used are `src/liballoc/tests/str.rs` and `src/liballoc/tests/str.rs`.

Rollup of 11 pull requests Successful merges: - #51807 (Deprecation of str::slice_unchecked(_mut)) - #52051 (mem::swap the obvious way for types smaller than the SIMD optimization's block size) - #52465 (Add CI test harness for `thumb*` targets. [IRR-2018-embedded]) - #52507 (Reword when `_` couldn't be inferred) - #52508 (Document that Unique::empty() and NonNull::dangling() aren't sentinel values) - #52521 (Fix links in rustdoc book.) - #52581 (Avoid using `#[macro_export]` for documenting builtin macros) - #52582 (Typo) - #52587 (Add missing backtick in UniversalRegions doc comment) - #52594 (Run the error index tool against the sysroot libdir) - #52615 (Added new lines to .gitignore.)

Version 1.29.0 (2018-09-13) ========================== Compiler -------- - [Bumped minimum LLVM version to 5.0.][51899] - [Added `powerpc64le-unknown-linux-musl` target.][51619] - [Added `aarch64-unknown-hermit` and `x86_64-unknown-hermit` targets.][52861] Libraries --------- - [`Once::call_once` now no longer requires `Once` to be `'static`.][52239] - [`BuildHasherDefault` now implements `PartialEq` and `Eq`.][52402] - [`Box<CStr>`, `Box<OsStr>`, and `Box<Path>` now implement `Clone`.][51912] - [Implemented `PartialEq<&str>` for `OsString` and `PartialEq<OsString>` for `&str`.][51178] - [`Cell<T>` now allows `T` to be unsized.][50494] - [`SocketAddr` is now stable on Redox.][52656] Stabilized APIs --------------- - [`Arc::downcast`] - [`Iterator::flatten`] - [`Rc::downcast`] Cargo ----- - [Cargo can silently fix some bad lockfiles ][cargo/5831] You can use `--locked` to disable this behaviour. - [`cargo-install` will now allow you to cross compile an install using `--target`][cargo/5614] - [Added the `cargo-fix` subcommand to automatically move project code from 2015 edition to 2018.][cargo/5723] Misc ---- - [`rustdoc` now has the `--cap-lints` option which demotes all lints above the specified level to that level.][52354] For example `--cap-lints warn` will demote `deny` and `forbid` lints to `warn`. - [`rustc` and `rustdoc` will now have the exit code of `1` if compilation fails, and `101` if there is a panic.][52197] - [A preview of clippy has been made available through rustup.][51122] You can install the preview with `rustup component add clippy-preview` Compatibility Notes ------------------- - [`str::{slice_unchecked, slice_unchecked_mut}` are now deprecated.][51807] Use `str::get_unchecked(begin..end)` instead. - [`std::env::home_dir` is now deprecated for its unintuitive behaviour.][51656] Consider using the `home_dir` function from https://crates.io/crates/dirs instead. - [`rustc` will no longer silently ignore invalid data in target spec.][52330] [52861]: rust-lang/rust#52861 [52656]: rust-lang/rust#52656 [52239]: rust-lang/rust#52239 [52330]: rust-lang/rust#52330 [52354]: rust-lang/rust#52354 [52402]: rust-lang/rust#52402 [52103]: rust-lang/rust#52103 [52197]: rust-lang/rust#52197 [51807]: rust-lang/rust#51807 [51899]: rust-lang/rust#51899 [51912]: rust-lang/rust#51912 [51511]: rust-lang/rust#51511 [51619]: rust-lang/rust#51619 [51656]: rust-lang/rust#51656 [51178]: rust-lang/rust#51178 [51122]: rust-lang/rust#51122 [50494]: rust-lang/rust#50494 [cargo/5614]: rust-lang/cargo#5614 [cargo/5723]: rust-lang/cargo#5723 [cargo/5831]: rust-lang/cargo#5831 [`Arc::downcast`]: https://doc.rust-lang.org/std/sync/struct.Arc.html#method.downcast [`Iterator::flatten`]: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.flatten [`Rc::downcast`]: https://doc.rust-lang.org/std/rc/struct.Rc.html#method.downcast

Deprecation of str::slice_uncheked(_mut)

7c31609

rust-highfive assigned Mark-Simulacrum Jun 26, 2018

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2018

This comment has been minimized.

Sign in to view

removed slice_uncheked from src/liballoc/tests/str.rs

aaf2004

kennytm reviewed Jun 26, 2018

View reviewed changes

kennytm added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Jun 26, 2018

review fix

f1cc8b2

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Jul 9, 2018

kennytm added S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 9, 2018

Mark-Simulacrum assigned SimonSapin and unassigned Mark-Simulacrum Jul 9, 2018

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Jul 11, 2018

kennytm added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-team Status: Awaiting decision from the relevant subteam (see the T-<team> label). labels Jul 11, 2018

alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 11, 2018

deprecation message improvement

808bcfb

rfcbot added the finished-final-comment-period The final comment period is finished for this PR / Issue. label Jul 21, 2018

rfcbot removed the final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. label Jul 21, 2018

kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Jul 21, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 21, 2018

kennytm mentioned this pull request Jul 21, 2018

Rollup of 11 pull requests #52588

Closed

kennytm mentioned this pull request Jul 22, 2018

Rollup of 11 pull requests #52616

Merged

bors merged commit 808bcfb into rust-lang:master Jul 22, 2018

Deprecation of str::slice_unchecked(_mut) #51807

Deprecation of str::slice_unchecked(_mut) #51807

Uh oh!

Conversation

newpavlov commented Jun 26, 2018

Uh oh!

rust-highfive commented Jun 26, 2018

Uh oh!

This comment has been minimized.

kennytm Jun 26, 2018

Choose a reason for hiding this comment

Uh oh!

kennytm Jun 26, 2018

Choose a reason for hiding this comment

Uh oh!

TimNN commented Jul 3, 2018

Uh oh!

pietroalbini commented Jul 9, 2018

Uh oh!

SimonSapin commented Jul 9, 2018

Uh oh!

rfcbot commented Jul 9, 2018 • edited by sfackler Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rfcbot commented Jul 11, 2018

Uh oh!

RalfJung commented Jul 12, 2018

Uh oh!

SimonSapin commented Jul 12, 2018

Uh oh!

RalfJung commented Jul 12, 2018

Uh oh!

rfcbot commented Jul 21, 2018

Uh oh!

alexcrichton commented Jul 21, 2018

Uh oh!

bors commented Jul 21, 2018

Uh oh!

kennytm commented Jul 21, 2018

Uh oh!

Uh oh!

rfcbot commented Jul 9, 2018 •

edited by sfackler

Loading